From 9e07ddcdf5c0ad67b0d4f9d37c9242d4cbc40157 Mon Sep 17 00:00:00 2001 From: gdlbo <41114720+gdlbo@users.noreply.github.com> Date: Sat, 25 Feb 2023 19:24:37 +0300 Subject: [PATCH] improvements --- .../java/ru/vtosters/lite/hooks/DockBarInjector.java | 10 ++++------ .../java/ru/vtosters/lite/themes/utils/ArscEditor.java | 4 ++-- .../vtosters/lite/ui/wallpapers/ConvolutionMatrix.java | 10 ++++------ 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/app/src/main/java/ru/vtosters/lite/hooks/DockBarInjector.java b/app/src/main/java/ru/vtosters/lite/hooks/DockBarInjector.java index ee4344c06..243211d76 100644 --- a/app/src/main/java/ru/vtosters/lite/hooks/DockBarInjector.java +++ b/app/src/main/java/ru/vtosters/lite/hooks/DockBarInjector.java @@ -108,10 +108,8 @@ public class DockBarInjector { private static void removeAllChildren(ViewGroup view) { for (int i = 0; i < view.getChildCount(); i++) { - if (view instanceof ViewGroup) { - removeAllChildren((ViewGroup) view.getChildAt(i)); - view.removeAllViews(); - } + removeAllChildren((ViewGroup) view.getChildAt(i)); + view.removeAllViews(); } } @@ -247,8 +245,8 @@ public class DockBarInjector { } try { JSONArray jSONArray = new JSONArray(); - for (int i = 0; i < arrayList.size(); i++) { - jSONArray.put(new JSONObject().put("name", arrayList.get(i))); + for (String s : arrayList) { + jSONArray.put(new JSONObject().put("name", s)); } for (int i2 = 0; i2 < arr.length(); i2++) { jSONArray.put(arr.getJSONObject(i2)); diff --git a/app/src/main/java/ru/vtosters/lite/themes/utils/ArscEditor.java b/app/src/main/java/ru/vtosters/lite/themes/utils/ArscEditor.java index c37f8b926..d25e6b705 100644 --- a/app/src/main/java/ru/vtosters/lite/themes/utils/ArscEditor.java +++ b/app/src/main/java/ru/vtosters/lite/themes/utils/ArscEditor.java @@ -19,8 +19,8 @@ public class ArscEditor { final var id = BinaryResourceIdentifier.create(packageChunk.getId(), typeSpecChunk.getId(), entry.getKey()); - for (int i = 0; i < colorIds.length; ++i) { - if (colorIds[i] != id.resId()) continue; + for (int colorId : colorIds) { + if (colorId != id.resId()) continue; final var value = entry.getValue(); value.updateValue(new BinaryResourceValue(8, value.value().type(), color /*colors[i]*/)); diff --git a/app/src/main/java/ru/vtosters/lite/ui/wallpapers/ConvolutionMatrix.java b/app/src/main/java/ru/vtosters/lite/ui/wallpapers/ConvolutionMatrix.java index 1e195f190..9fd3d434d 100644 --- a/app/src/main/java/ru/vtosters/lite/ui/wallpapers/ConvolutionMatrix.java +++ b/app/src/main/java/ru/vtosters/lite/ui/wallpapers/ConvolutionMatrix.java @@ -3,6 +3,8 @@ package ru.vtosters.lite.ui.wallpapers; import android.graphics.Bitmap; import android.graphics.Color; +import java.util.Arrays; + public class ConvolutionMatrix { public static final int SIZE = 3; @@ -83,17 +85,13 @@ public class ConvolutionMatrix { public void setAll(double value) { for (int x = 0; x < SIZE; ++x) { - for (int y = 0; y < SIZE; ++y) { - Matrix[x][y] = value; - } + Arrays.fill(Matrix[x], value); } } public void applyConfig(double[][] config) { for (int x = 0; x < SIZE; ++x) { - for (int y = 0; y < SIZE; ++y) { - Matrix[x][y] = config[x][y]; - } + System.arraycopy(config[x], 0, Matrix[x], 0, SIZE); } } } \ No newline at end of file